Skip to content

feat(gateway): add create commands - #1899

Draft
aidandaly24 wants to merge 9 commits into
feat/iam-candidate-policy-swapfrom
feat/gateway-create-cud
Draft

feat(gateway): add create commands#1899
aidandaly24 wants to merge 9 commits into
feat/iam-candidate-policy-swapfrom
feat/gateway-create-cud

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add Gateway, Target, and Rule create commands
  • create a deterministic, tagged, least-privilege Gateway execution role when --role-arn is omitted
  • stage complete Gateway and Target role-policy candidates before service creation
  • remove new candidates on failed creation while preserving predecessor policies
  • preserve customer-managed roles without IAM mutation
  • keep the command surface limited to the installed service SDK model

Stack

Testing

  • focused Gateway Create suite: 52 pass
  • source-scoped TypeScript, lint, formatting, and bundle build
  • live AWS HTTP and MCP Gateway creation with CLI-owned roles
  • live MCP Lambda Target creation confirmed one policy granting only the requested Lambda

This was referenced Aug 4, 2026
Draft
Draft
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 4, 2026
@codecov-commenter

codecov-commenter commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.90592% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.09%. Comparing base (36075b9) to head (f0c80fd).

Files with missing lines Patch % Lines
src/handlers/gateway/mutations.ts 76.25% 19 Missing ⚠️
src/handlers/gateway/create/index.tsx 91.52% 10 Missing ⚠️
src/core/gatewayExecutionRolePolicy.ts 98.33% 7 Missing ⚠️
src/handlers/gateway/target/create/index.tsx 94.94% 5 Missing ⚠️
src/core/gatewayExecutionRole.ts 97.87% 4 Missing ⚠️
src/handlers/gateway/rule/create/index.tsx 95.55% 2 Missing ⚠️
Additional details and impacted files 
@@                        Coverage Diff                         @@
##           feat/iam-candidate-policy-swap    #1899      +/-   ##
==================================================================
- Coverage                           96.11%   96.09%   -0.02%     
==================================================================
  Files                                 225      231       +6     
  Lines                               11384    12531    +1147     
==================================================================
+ Hits                                10942    12042    +1100     
- Misses                                442      489      +47

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 4, 2026
@aidandaly24
aidandaly24 marked this pull request as ready for review August 4, 2026 14:58
@aidandaly24
aidandaly24 marked this pull request as draft August 4, 2026 15:01
@aidandaly24
aidandaly24 changed the base branch from refactor to feat/iam-candidate-policy-swap August 4, 2026 16:59
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch from 9a3bf67 to c507614 Compare August 4, 2026 16:59
@aidandaly24 aidandaly24 mentioned this pull request Aug 4, 2026
Open
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 4, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch from c507614 to 27fd3b5 Compare August 4, 2026 17:57
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch 2 times, most recently from e005077 to 3271c5a Compare August 4, 2026 18:32
@aidandaly24
aidandaly24 force-pushed the feat/gateway-create-cud branch from 3271c5a to 13c4bb7 Compare August 4, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/xl PR size: XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidandaly24 @codecov-commenter